Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk import documentation #282

Merged
merged 8 commits into from
Nov 20, 2024
Merged

Bulk import documentation #282

merged 8 commits into from
Nov 20, 2024

Conversation

tstirrat15
Copy link
Contributor

Description

We've gotten questions around this from several users and the behavior isn't entirely intuitive. This documents how bulk importing works and provides an example.

Changes

  • Add documentation

Testing

Review docs. See that stuff makes sense.

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 2 resolved Nov 20, 2024 3:26pm

@sohanmaheshwar
Copy link
Contributor

Hey @tstirrat15

Some questions / comments I had:

  1. Is the RetryableClient method available only for the authzed-go client or is it available for other client libraries as well? I did see the line "Similar logic can be implemented using the other client libraries.". IMHO, if the method is available for all client libraries - we can use the same client library as the example snippet for Bulk Import and for Retrying. For ex: Using authzed-dotnet or authzed-go for both.

  2. Alternately, what do you think about adding examples for Bulk Import for all client libraries in a tabbed format? I see we have support in Go & Py atleast so devs could read it in their language of choice and use as needed.

Tabs that look like this:
Screenshot 2024-11-14 at 14 50 59

  1. Is there a place where the Skip and Touch semantics are explained in-depth? If so, we could link that just to avoid any ambiguity about that behaviour.

Minor typo in API name
Copy link
Contributor

@sohanmaheshwar sohanmaheshwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Minor nit - For the first code snippet - should we use "Csharp" or "dotnet" ? Asking as we've used dotnet in our client libraries.

@tstirrat15 tstirrat15 merged commit e70a12f into main Nov 20, 2024
9 checks passed
@tstirrat15 tstirrat15 deleted the bulk-import-documentation branch November 20, 2024 15:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants