Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prealloc 500 error by making prealloc in tangoREST.py async #243

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

20wildmanj
Copy link
Contributor

Fixes #242. Tested by running pathon tango-cli.py -k [KEY] --prealloc --num [count] --image [image] --vmms localDocker within Tango/clients/

@20wildmanj 20wildmanj requested a review from damianhxy January 13, 2024 10:05
Copy link

coderabbitai bot commented Jan 13, 2024

Walkthrough

Walkthrough

The change involves updating the prealloc method to be asynchronous, addressing an issue where preallocate requests would allocate slots but fail due to a TypeError. The modification was made to ensure that the function operates correctly in an asynchronous environment, likely resolving the internal server error by fixing the improper use of a dictionary in an 'await' expression.

Changes

File Path Change Summary
.../tangoREST.py Modified prealloc to be an asynchronous function.

Assessment against linked issues

Objective Addressed Explanation
Expected behavior of preallocate request to return a successful result (#242)
Correction of TypeError related to dictionary usage in 'await' expression (#242)
Reproduction steps involving preallocate with specific key, count, and image parameters (#242) Without the specific changes or the code snippet, it's unclear if the reproduction steps are directly addressed. However, the async modification suggests that the TypeError might be resolved.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Member

@damianhxy damianhxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-01-13 at 20 56 51 Screenshot 2024-01-13 at 20 56 59

LGTM

@20wildmanj 20wildmanj merged commit 182e322 into master Jan 13, 2024
1 check passed
@20wildmanj 20wildmanj deleted the joeywildman-fix-prealloc-async branch January 13, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prealloc requests fail
2 participants