-
Notifications
You must be signed in to change notification settings - Fork 743
[nix] Migrate linter installation to nix #3826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: nix-golang
Are you sure you want to change the base?
Conversation
0500b41
to
66d0a61
Compare
136b062
to
dcb56d9
Compare
This ensures dev shell users always have the required golang version.
6e15af6
to
b18c9d5
Compare
@StephenButtolph are you ok with this? |
Yes.
Unless otherwise specified, I am the only person that default as an owner of a file. The change in the |
This PR is maybe not the best path forward, I did some work in hypersdk to ensure consistent installation of golang binaries that is probably preferable to having to package golang modules with nix: |
Why this should be merged
Migrate linter installation to nix to reduce installation time and ensure consistency between CI and local usage.
If seeing VCS errors when running lint.sh under a nix shell on macos, the following commands should fix it:
Reference: NixOS/nixpkgs#355486 (comment)
How this works
How this was tested
CI
Need to be documented in RELEASES.md?
N/A
TODO