-
Notifications
You must be signed in to change notification settings - Fork 154
WIP: Libevm upstream sync with pivot change #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
alarso16
wants to merge
230
commits into
libevm-upstream-sync
Choose a base branch
from
alarso16/libevm-upstream-sync
base: libevm-upstream-sync
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove the bls dependency --------- Co-authored-by: Darioush Jalali <[email protected]>
* Release notes and avalanchego update * restore avago version * bump avago to master * ammend notes * go mod tidy * bump version * update notes
Co-authored-by: Darioush Jalali <[email protected]>
* new atomic pkg * bump avago * bump versions * change newimport clk to time * move utils * bump avago * go mod tidy * use address methods from avago * bump avago * bump e2e avago version
* new atomic pkg * bump avago * bump versions * move attomic gossip * lint * change newimport clk to time * move utils * bump avago * go mod tidy * update releases md * use address methods from avago * bump avago * bump e2e avago version * Update plugin/evm/atomic/gossip_test.go Co-authored-by: Quentin McGaw <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> * Update plugin/evm/atomic/mempool.go Co-authored-by: Quentin McGaw <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> * Update plugin/evm/config/config.go Co-authored-by: Quentin McGaw <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> * Update plugin/evm/atomic/tx_heap.go Co-authored-by: Quentin McGaw <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> * Update plugin/evm/config/config.go Co-authored-by: Quentin McGaw <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> * fix reviews --------- Signed-off-by: Ceyhun Onur <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> Co-authored-by: Quentin McGaw <[email protected]>
Co-authored-by: Quentin McGaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]>
* header.yml is missing so removing ineffective go-license * Remove unneeded source constants * Remove unneeded source versions * Use go generate commands to generate mocks * Remove the need to install mockgen in the script * Add mock-up-to-date step to test CI workflow * Remove all mocks before generating them in CI * Add generate command for non-tracked mock (Note using source mode was compulsory due to CGO) * Use bash shell for mock check step * Remove script mock.gen.sh * docs(contributing): add mocks section * mockgen version used is the one defined in go.mod - requires a `tools.go` blank importing golang.org/x/tools/imports in order to have the `golang.org/x/tools` dependency satisfied for mockgen v0.4 - less future deltas when upgrading mockgen * ci: use more precise go generate regex * Add `git add --intent-to-add --all` to detect untracked files * Add copyright notices
* small changes * relevant warp changes * use wrapped db package * nit * equivalent to subnet-evm 843e3f7 * add multiatch docker build to support arm (#1417) * remove build_docker_image.sh --------- Co-authored-by: Ceyhun Onur <[email protected]>
Co-authored-by: Quentin McGaw <[email protected]>
Co-authored-by: Quentin McGaw <[email protected]>
Co-authored-by: Ceyhun Onur <[email protected]>
…blocks (#719) - default behavior for pruning mode to reject blocks before the 32 blocks preceding the last accepted block - default behavior for archive mode to reject blocks before ~24h worth of blocks preceding the last accepted block - archive mode new option `historical-proof-query-window` to customize the blocks window, or set it to 0 to accept any block number
Co-authored-by: maskpp <[email protected]> Co-authored-by: Aaron Chen <[email protected]> Co-authored-by: Shiming Zhang <[email protected]> Co-authored-by: Felix Lange <[email protected]> Co-authored-by: Nathan <[email protected]> Co-authored-by: Eric <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]> Co-authored-by: Quentin McGaw <[email protected]>
…ialization, fixed gentrie error
…g, attempt to clean shared memory
Signed-off-by: Yacov Manevich <[email protected]>
- changes applied from comments on the review of #820 - suggested changes from the review on #828 - add test to check PredicateBytesFromExtra is the inverse of SetPredicateBytesInExtra Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]>
Signed-off-by: Darioush Jalali <[email protected]> Co-authored-by: Quentin McGaw <[email protected]>
…erface used by x/sync. Both are managed by the dynamic syncer
…schemes in syncer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a few things that I should mention that are mostly related to structure.
downloader.go
logic is very similar to that of thedownloader.go
in geth. TheSnapSync()
method essentiallyprocessSnapSyncContent
. I removed a lot of the (seemingly) excessive logic here, but it seems to successfully move the pivot with rather rare errors.stateSyncerclient
toDownloader
is necessary because we need to block from queueing blocks once we finish the state sync, and then once the queue is cleared, we release the lock, allowing blocks to be verified as normal.Downloader
weren't my idea - copied from geth with minimal revision. I'm not married to it, if you have a more readable suggestion.My next steps:
TipToBuffer
and adjusting the pivot interval to find a "sweet spot".