-
Notifications
You must be signed in to change notification settings - Fork 156
reduce customtypes import #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+24
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
commented
May 4, 2025
qdm12
reviewed
May 5, 2025
…s/coreth into ceyonur/reduce-customtype-import
…s/coreth into ceyonur/reduce-customtype-import
Signed-off-by: Ceyhun Onur <[email protected]>
qdm12
reviewed
May 5, 2025
…s/coreth into ceyonur/reduce-customtype-import
tsachiherman
reviewed
May 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you fix the
no required module provides package github.com/ava-labs/coreth/plugin/evm/customlogs; to add it:
lint message ?
maybe you forgot to add customlogs
to this PR ?
it was gitignored |
michaelkaplan13
approved these changes
May 7, 2025
qdm12
approved these changes
May 8, 2025
Co-authored-by: Quentin McGaw <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Quentin McGaw <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Importing
customtypes
andparams
pkg causes side-effects oflibevm
. We should reduce importing of those pkgs in custom-facing client code.AvalancheGo Follow-up PR: ava-labs/avalanchego#3918
How this works
This pull request refactors logging functionality by consolidating and renaming the logging package, alongside minor code improvements and cleanup. The most significant changes include replacing the
log
andcustomtypes
packages with a unifiedcustomlog
package, updating imports and references accordingly, and simplifying variable declarations for consistency.Logging Refactor:
log
package tocustomlog
across multiple files, includingformat.go
,handler.go
, andlogger.go
, and updated their package declarations and references.customtypes.FlattenLogs
withcustomlog.FlattenLogs
incore/blockchain.go
,eth/filters/filter.go
, and other files.Code Cleanup and Simplification:
Version
andBlockExtraData
) and associated logic fromethclient/ethclient.go
to streamline block handling, to prevent importingcustomtypes
and libevm side-effects.How this was tested
Added to
imports_test
Need to be documented?
No
Need to update RELEASES.md?
Probably