Skip to content

Use FilterOutputStream in Output Buffer #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Use FilterOutputStream in Output Buffer #294

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc41343
Use FilterOutputStream for Buffer
SentryMan Aug 26, 2025
92f9d07
Update BufferedOutStream.java
SentryMan Aug 27, 2025
7f6d27f
Update BufferedOutStream.java
SentryMan Aug 27, 2025
60899ef
Update BufferedOutStream.java
SentryMan Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 17 additions & 20 deletions avaje-jex/src/main/java/io/avaje/jex/core/BufferedOutStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,19 @@
package io.avaje.jex.core;

import java.io.ByteArrayOutputStream;
import java.io.FilterOutputStream;
import java.io.IOException;
import java.io.OutputStream;

import com.sun.net.httpserver.HttpExchange;

final class BufferedOutStream extends OutputStream {
final class BufferedOutStream extends FilterOutputStream {

private final long max;
private final JdkContext context;
private ByteArrayOutputStream buffer;
private OutputStream stream;
private boolean jdkOutput;
private long count;

BufferedOutStream(JdkContext context, int initial, long max) {
super(context.exchange().getResponseBody());
this.context = context;
this.max = max;

Expand All @@ -28,12 +27,12 @@ final class BufferedOutStream extends OutputStream {

@Override
public void write(int b) throws IOException {
if (stream != null) {
stream.write(b);
if (jdkOutput) {
out.write(b);
} else {
if (count++ > max) {
useJdkOutput();
stream.write(b);
out.write(b);
return;
}
buffer.write(b);
Expand All @@ -42,37 +41,35 @@ public void write(int b) throws IOException {

@Override
public void write(byte[] b, int off, int len) throws IOException {
if (stream != null) {
stream.write(b, off, len);
if (jdkOutput) {
out.write(b, off, len);
} else {
count += len;
if (count > max) {
useJdkOutput();
stream.write(b, off, len);
out.write(b, off, len);
return;
}
buffer.write(b, off, len);
}
}

/** Use the underlying HttpExchange. Chunking the response if needed */
/** Use the underlying OutputStream. Chunking the response if needed */
private void useJdkOutput() throws IOException {
final HttpExchange exchange = context.exchange();
// if a manual content-length is set, honor that instead of chunking
String length = context.responseHeader(Constants.CONTENT_LENGTH);
exchange.sendResponseHeaders(context.statusCode(), length == null ? 0 : Long.parseLong(length));
stream = exchange.getResponseBody();
var length = context.responseHeader(Constants.CONTENT_LENGTH);
context.exchange().sendResponseHeaders(context.statusCode(), length == null ? 0 : Long.parseLong(length));
jdkOutput = true;
// empty the existing buffer
if (buffer != null) {
buffer.writeTo(stream);
buffer = null;
buffer.writeTo(out);
}
}

@Override
public void close() throws IOException {
if (stream != null) {
stream.close();
if (jdkOutput) {
out.close();
} else {
context.write(buffer.toByteArray());
}
Expand Down