Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] [REST] Should cacth NoNode Exception instead of throw, when list kyuubi engines #4424

Closed
3 of 4 tasks
zwangsheng opened this issue Feb 27, 2023 · 0 comments · May be fixed by awesome-kyuubi/kyuubi#6
Closed
3 of 4 tasks

[Bug] [REST] Should cacth NoNode Exception instead of throw, when list kyuubi engines #4424

zwangsheng opened this issue Feb 27, 2023 · 0 comments · May be fixed by awesome-kyuubi/kyuubi#6
Labels
kind:bug This is a clearly a bug priority:major

Comments

@zwangsheng
Copy link
Contributor

zwangsheng commented Feb 27, 2023 •
edited
Loading

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

When kyuubi server start without submit any engine, zookeeper won't create engineSpace node.

When user list kyuubi engines, will face 500 code instead of null.
WX20230227-184422

Affects Version(s)

master

Kyuubi Server Log Output

1677494619877

Kyuubi Engine Log Output

No response

Kyuubi Server Configurations

No response

Kyuubi Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to fix.
  • No. I cannot submit a PR at this time.
@zwangsheng zwangsheng added kind:bug This is a clearly a bug priority:major labels Feb 27, 2023
@zwangsheng zwangsheng mentioned this issue Feb 27, 2023
Closed
3 tasks
yanghua pushed a commit to yanghua/incubator-kyuubi that referenced this issue Apr 13, 2023
@zwangsheng @yanghua
[KYUUBI apache#4424][REST] Catch No Node Exception, when list kyuubi …
76378a3 
…engines

### _Why are the changes needed?_

Close apache#4424

Catch No Node Exception, when list kyuubi engines

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [x] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request

![WX20230227-184957](https://user-images.githubusercontent.com/52876270/221544376-2f0d6b4b-0bc4-446e-abb1-d0c79211aea4.png)

Closes apache#4425 from zwangsheng/kyuubi-4424.

Closes apache#4424

3052b15 [zwangsheng] [Kyuubi apache#4424] Fix scala style
74825cf [zwangsheng] [Kyuubi apache#4424] Throw User Friendly Exception
7e8363c [zwangsheng] [Kyuubi apache#4424] Remove usless file & catch subException
4a3c469 [zwangsheng] [Kyuubi apache#4424] Catch cacth No Node Exception, when list kyuubi engines

Authored-by: zwangsheng <[email protected]>
Signed-off-by: ulyssesyou <[email protected]>
@yanghua yanghua mentioned this issue Apr 13, 2023
Open
6 tasks
yanghua pushed a commit to yanghua/incubator-kyuubi that referenced this issue Apr 13, 2023
@zwangsheng @yanghua
[KYUUBI apache#4424][REST] Catch No Node Exception, when list kyuubi …
5ab2efa 
…engines

### _Why are the changes needed?_

Close apache#4424

Catch No Node Exception, when list kyuubi engines

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [x] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request

![WX20230227-184957](https://user-images.githubusercontent.com/52876270/221544376-2f0d6b4b-0bc4-446e-abb1-d0c79211aea4.png)

Closes apache#4425 from zwangsheng/kyuubi-4424.

Closes apache#4424

3052b15 [zwangsheng] [Kyuubi apache#4424] Fix scala style
74825cf [zwangsheng] [Kyuubi apache#4424] Throw User Friendly Exception
7e8363c [zwangsheng] [Kyuubi apache#4424] Remove usless file & catch subException
4a3c469 [zwangsheng] [Kyuubi apache#4424] Catch cacth No Node Exception, when list kyuubi engines

Authored-by: zwangsheng <[email protected]>
Signed-off-by: ulyssesyou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:bug This is a clearly a bug priority:major
Projects
None yet
Milestone
No milestone
1 participant
@zwangsheng