Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to biomejs #1167

Merged
merged 7 commits into from
Nov 4, 2024
Merged

chore: migrate to biomejs #1167

merged 7 commits into from
Nov 4, 2024

Conversation

kellertk
Copy link
Member

@kellertk kellertk commented Sep 27, 2024

Migrating from eslint to biomejs and jest to vitest.

Note: There are a lot of changes here due to the linter change, which slightly modified style on a few files. Also the tests were completely rewritten to be clearer. Coverage % is slightly less.

@kellertk kellertk requested a review from tim-finnigan November 2, 2024 23:10
@kellertk kellertk marked this pull request as ready for review November 2, 2024 23:10
@kellertk kellertk dismissed tim-finnigan’s stale review November 4, 2024 16:34

The merge-base changed after approval.

tim-finnigan
tim-finnigan previously approved these changes Nov 4, 2024
@kellertk kellertk requested a review from tim-finnigan November 4, 2024 18:09
tim-finnigan
tim-finnigan previously approved these changes Nov 4, 2024
@kellertk kellertk dismissed tim-finnigan’s stale review November 4, 2024 18:10

The merge-base changed after approval.

@kellertk kellertk enabled auto-merge (squash) November 4, 2024 18:16
@kellertk kellertk closed this Nov 4, 2024
auto-merge was automatically disabled November 4, 2024 18:17

Pull request was closed

@kellertk kellertk reopened this Nov 4, 2024
@kellertk kellertk merged commit ccbdafa into main Nov 4, 2024
11 checks passed
@kellertk kellertk deleted the biomejs branch November 6, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants