fix(IoT): Fixing a potential race condition in the timer ring queue #5461
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
AWSMQTTSession.timerRing
is aNSArray
with each element being aNSSet
. This can potentially cause a race condition that leads to a crash, if two different threads attempt to access/modify these collections at the same time.I'm creating a new
AWSMQTTTimerRing
class that encapsulates these collections and protects their access with aNSLock
, similar to what I previously did forAWSIoTAtomicDictionary
Check points:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.