Fixes dialyzer error due to proplist and Keyword incompatibility #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keyword always expects {key(), value()} items.
onno-vos-dev
approved these changes
Mar 5, 2025
|
@jessestimpson How do you want to deal with this PR in lights of: aws-beam/aws-codegen#121? Do you want me to wait rolling out a release with this fix until we converge on a fix for that issue or would you like to see a release rolled out containing this fix? I don't really mind either way, letting you decide before I merge 👍 |
|
@onno-vos-dev I'm happy to wait on a release. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS.HTTPClient.Hackney.request/5has a type error in the implementation which causes dialyzer to fail:Keywordalways expects items to be of the form{key(), value()}. However, the code is including item:with_body, in the style oft:proplists.proplist/0.Changing the order of execution resolves the typing issue.