-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ec2 template with version #155
base: main
Are you sure you want to change the base?
Ec2 template with version #155
Conversation
Hi @rkurduka. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Issues go stale after 180d of inactivity. |
Stale issues rot after 60d of inactivity. |
Hi everyone. This is a rather critical feature of ACK imo as it's a showstopper for customizing managed EKS nodes. Any chance we could revisit this PR? |
I will also add that the Services Page in the ACK docs indicates that the ec2-controller is GA but lacking the ability to create and maintain a fundamental feature like LaunchTemplates seems like a significant enough gap in it's functionality to consider it GA. This might be worth a little bit more attention. |
7838bee
to
cc0a8ce
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rkurduka The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rkurduka: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Issue #, if available:
1841
Description of changes:
New resource added "launchtemplateversion"
There is separate PR for "launchtemplate" already open and in progress #151
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.