Capacity reservations feature implementation #235
Conversation
…D operations for Tags
|
Hi @fizashaikh. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ack-prow
bot
added
the
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fizashaikh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fizashaikh
changed the title
|
/ok-to-test |
ack-prow
bot
added
ok-to-test
|
at first glance, this LGTM, @michaelhtm can you PTAL |
|
/test ec2-verify-attribution |
There was a problem hiding this comment.
Hey @fizashaikh, thanks for contributing!
Everything lgtm, can you please resolve the conflict?
Thanks
Thanks for reviewing @michaelhtm ! All conflicts are resolved now 👍 |
There was a problem hiding this comment.
Hi @fizashaikh. apologies for the back and forth. I have a couple more comments about this PR. Thanks!
| AvailabilityZoneID *string `json:"availabilityZoneID,omitempty"` | ||
| // Unique, case-sensitive identifier that you provide to ensure the idempotency | ||
| // of the request. For more information, see Ensure Idempotency (https://docs.aws.amazon.com/AWSEC2/latest/APIReference/Run_Instance_Idempotency.html). | ||
| ClientToken *string `json:"clientToken,omitempty"` |
There was a problem hiding this comment.
can we ignore clientToken? it might lead to some issues..if it's required we can randomly generate the value using custom code
| // actually making the request, and provides an error response. If you have | ||
| // the required permissions, the error response is DryRunOperation. Otherwise, | ||
| // it is UnauthorizedOperation. | ||
| DryRun *bool `json:"dryRun,omitempty"` |
| EndDate *metav1.Time `json:"endDate,omitempty"` | ||
| // Indicates the way in which the Capacity Reservation ends. A Capacity Reservation | ||
| // can have one of the following end types: | ||
| // | ||
| // - unlimited - The Capacity Reservation remains active until you explicitly | ||
| // cancel it. Do not provide an EndDate if the EndDateType is unlimited. | ||
| // | ||
| // - limited - The Capacity Reservation expires automatically at a specified | ||
| // date and time. You must provide an EndDate value if the EndDateType value | ||
| // is limited. | ||
| EndDateType *string `json:"endDateType,omitempty"` |
There was a problem hiding this comment.
nit: not sure if this should be required, but can we have custom code validating the assignment of these fields?
| // | ||
| // You can request a future-dated Capacity Reservation between 5 and 120 days | ||
| // in advance. | ||
| StartDate *metav1.Time `json:"startDate,omitempty"` |
There was a problem hiding this comment.
î same for this one? with end-date
Issue: aws-controllers-k8s/community#2234
Description of changes:
This change implements capacity reservations feature in ec2 operator.
It adds e2e tests for the capacity reservations CRUD functionality.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.