Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2090/route table order dependence #236

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Issue 2090/route table order dependence #236

wants to merge 3 commits into from

Conversation

gfrey
Copy link
Contributor

@gfrey gfrey commented Jan 31, 2025 •
edited by michaelhtm
Loading

Fixes issue #2090

Description of changes:

  • Configure generator for RouteTable to ignore the Routes from the generated delta code.
  • Extend the customPreCompare code to take care of the routes (computing the delta ignoring the order of routes).
  • Added unit test for the custom code.
  • Change the syncRoutes code to use the delta from the compare phase.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Gereon Frey added 2 commits January 31, 2025 14:31
Make routes order independent
6637289 
In the past the routes were not order independent. Whenever the API
would return a different order than specified, the routes would be
deleted and recreated. The `getMatchingRoute` code also returned the
first route that would have a matching field like the
VPCPeeringConnectionId. This resulted in routes not being stable.

Now the `customPreCompare` handles routes properly, i.e. is order
independent. Also the `syncRoutes` uses the computed diff, to create or
delete the according routes.
Add test for CustomerPreCompare
94de6b4
@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 31, 2025
@ack-prow ACK Prow
Copy link

ack-prow bot commented Jan 31, 2025

Hi @gfrey. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-prow ACK Prow
Copy link

ack-prow bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gfrey
Once this PR has been reviewed and has the lgtm label, please assign jlbutler for approval by writing /assign @jlbutler in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot requested review from a-hilaly and rushmash91 January 31, 2025 14:39
@gfrey
Copy link
Contributor Author

gfrey commented Jan 31, 2025 •
edited
Loading

@a-hilaly as discussed yesterday my attempt to address this:

  • I didn't include the generator output created locally; I assume it is taken care of by the pipeline.
  • I added a unit-test for my own piece of mind, even though the rest of the code doesn't have any (this required the go.mod change for the assertion library). If this isn't appropriate happy to change.
  • I tested this change locally in a limited setting. There it was working. Should we add more e2e tests for this?

@eqe-aws eqe-aws requested a review from michaelhtm February 3, 2025 17:28
@a-hilaly
Copy link
Member

a-hilaly commented Feb 3, 2025

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 3, 2025
Remove local routes when creating a route table
5be11fd 
This is the issue that made the e2e tests fail.
@gfrey
Copy link
Contributor Author

gfrey commented Feb 4, 2025

/retest

@ack-prow ACK Prow
Copy link

ack-prow bot commented Feb 4, 2025 •
edited
Loading

@gfrey: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ec2-verify-attribution 5be11fd link false /test ec2-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly Awaiting requested review from a-hilaly

@rushmash91 rushmash91 Awaiting requested review from rushmash91

@michaelhtm michaelhtm Awaiting requested review from michaelhtm

Assignees
No one assigned
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gfrey @a-hilaly