Skip to content

chore: Set cluster status to updating after successful update #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Set cluster status to updating after successful update #169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/resource/cluster/hook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ func clusterDeleting(r *resource) bool {
func returnClusterUpdating(r *resource) (*resource, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function description may need to updated. With this change forcing a re-queue is no longer necessary to see the "UPDATING" status.

msg := "Cluster is currently being updated"
ackcondition.SetSynced(r, corev1.ConditionFalse, &msg, nil)
r.ko.Status.Status = aws.String(string(svcsdktypes.ClusterStatusUpdating))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: If we're setting the ResourceSynced condition to false does that not already inform users that the Status fields may not reflect the state of the cluster in AWS?

return r, requeueAfterAsyncUpdate()
}

Expand Down Expand Up @@ -451,7 +452,7 @@ func (rm *resourceManager) updateVersion(
)
}

// Compure the next minor version of the desired version
// Compute the next minor version of the desired version
nextVersion, err := util.IncrementEKSMinorVersion(*latest.ko.Spec.Version)
if err != nil {
return ackerr.NewTerminalError(fmt.Errorf("failed to compute the next minor version: %v", err))
Expand Down