S3 CSI Addon - Support multiple buckets #1114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usmanatron
requested review from
aws-ia-ci,
shapirov103,
youngjeong46,
elamaran11 and
a team
as code owners
shapirov103
reviewed
Feb 11, 2025
There was a problem hiding this comment.
@usmanatron thank you for the contribution!
The change makes sense. The only concern is that it is a breaking change, so I will have to put it into 1.17 release and put a note on it. It is nothing major, but will require customers to apply a code fix if they are already using this addon.
lib/addons/s3-csi-driver/index.ts
Outdated
| */ | ||
| s3BucketName: string; | ||
| s3BucketNames: string[]; |
There was a problem hiding this comment.
Minor: since it is an s3-csi-driver, s3 is redundant in the names. If we are changing the names, let's make it just bucketNames.
|
@jesperalmstrom FYI ^^ |
shapirov103
reviewed
Feb 12, 2025
|
/do-e2e-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
Tweak the new S3 CSI Addon so it supports multiple S3 buckets. Looking at the CSI Driver itself, it does support multiple bucket; it's just the Service Account creation here which is currently constrained to a single bucket name.
One thing I'm not sure on is how this changes the Props object - it means consumers will have to change their usage. I could instead make s3BucketNames a
string | string[]to handle this, but I'm not sure if its worth the effort. What are your thoughts?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.