Feature: AWS CloudWatch Container Insights Addon #878
Conversation
…umentation for it with appropriate kubectl views
5herlocked
requested review from
aws-ia-ci,
parkand1,
shapirov103,
youngjeong46,
elamaran11 and
a team
as code owners
There was a problem hiding this comment.
@5herlocked Nice work on this new Addon. Some feedback.
- Doc can be improved aligning to enhanced CW features of the addon
- Managed Policy is missing
- CW logs functionality is missing
- mkdocs is missing
- adding to doc index is missing
- Are we not adding the blueprints stack. I would add and comment it.
|
|
||
| const app = new cdk.App(); | ||
|
|
||
| const addOn = new blueprints.addons.CloudWatchInsights(); |
There was a problem hiding this comment.
Could we show additional different variants of usage like EBS, CW Logs etc?
|
@5herlocked Wanted to check if you need any help to make progress on this addon. We want to add this with next blueprints release. |
|
I'll have this completed in a few weeks. |
Could you plan to add this for upcoming blueprints release? |
|
Resolved most of the requested changes, still working on the documentation. |
…bal stack and added conflict with cloudWatch logs addon
There was a problem hiding this comment.
Looks great, however the way it stands now it will be very confusing for the customers to select the right addon, especially choosing between ContainerInsightsAddon and this addon.
So let's apply the following changes:
- deprecate the current container insights addon (e..g similar to what we did for calico)
- update documentation for the deprecated addon and specify that there will be no maintenace on it and customers should move over to the CloudWatchInsightsAddon.
- In the docs for this addon, also call out that it is replacing the current CI addon.
There was a problem hiding this comment.
@5herlocked looks great!
@elamaran11 since this addon is not part of e2e test, have you tested it on your account?
|
@shapirov103 I was able to pull the fork and test, everything works fine. I can see CI in CW Console. Please proceed with e2e and merge. |
Issue #, if available: #872
Description of changes:
Added container insights add-on using CoreAddOn.
Added documentation for container insights along with what it's doing.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.