Add simple TTL for target manager cache #1678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefchien
force-pushed
the
recreate-log-group
branch
from
9d349c2 to
f71c61e
Compare
movence
previously approved these changes
May 14, 2025
sky333999
approved these changes
May 14, 2025
movence
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
If a log group gets deleted after it's been cached by the target manager, then it will never get recreated and logs will not be sent.
Description of changes
Adds a simple TTL check so if another request comes in for the same target, it will try again.
InitTargetis only ever called when the log group or stream doesn't exist, so it isn't a common call.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Updated unit tests.
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint