Add MemoryReservation support #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the40san
force-pushed
the
add_memory_reservation
branch
from
bc20827
to
df8d6d8
Compare
yinshiua
reviewed
Feb 21, 2017
| @@ -371,7 +372,8 @@ var servicesSchemaDataV2 = `{ | |||
| "volumes": {"type": "array", "items": {"type": "string"}, "uniqueItems": true}, | |||
| "volume_driver": {"type": "string"}, | |||
| "volumes_from": {"type": "array", "items": {"type": "string"}, "uniqueItems": true}, | |||
| "working_dir": {"type": "string"} | |||
| "working_dir": {"type": "string"}, | |||
| "memory_reservation": {"type": "integer"} | |||
There was a problem hiding this comment.
The vendor directories are auto generated by running godep save ./... in the /ecs-cli directory, and it can be overwritten.
I would prefer to do this the right way by updating libcompose. I've created an issue to see what's their plan of supporting mem_reservation. docker/libcompose#439
|
Support for version 2 : docker/compose#4563 |
|
Thank you. I'll start work to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #145
Added MemoryReservation option for ecs-cli.
Any docker-compose file format has no
memory_reservationdirective, but Amazon ECS has it.I think this is effective for production environment.
Could you review this please?