Add --context-file param to override cdk.context.json #576
Conversation
mavwolverine
had a problem deploying
to
integ-approval
GitHub Actions
Failure
| let PROJECT_CONTEXT = DEFAULT_PROJECT_CONTEXT; | ||
| export { PROJECT_CONTEXT }; |
There was a problem hiding this comment.
Let's not do this. It's going to be confusing if this value changes bases on whether load() has been called or not.
You can just update the name of the variable to DEFAULT_PROJECT_CONTEXT everywhere, or maybe for now just update the docblock.
| fs.existsSync(expandHomeDir(userProjectContextFile)) | ||
| ) { | ||
| info(`Using specified project context ${userProjectContextFile}`); | ||
| PROJECT_CONTEXT = userProjectContextFile; |
| if ( | ||
| userProjectContextFile && | ||
| typeof userProjectContextFile === 'string' && | ||
| fs.existsSync(expandHomeDir(userProjectContextFile)) |
There was a problem hiding this comment.
I don't think t the filepath should be considered relative to the user's home directory. It's also not what is done later on.
| @@ -122,6 +124,20 @@ export class Configuration { | |||
| public async load(): Promise<this> { | |||
| const userConfig = await loadAndLog(USER_DEFAULTS); | |||
| this._projectConfig = await loadAndLog(PROJECT_CONFIG); | |||
| var userProjectContextFile = this.commandLineArguments.subSettings(['contextFile']).get([]); | |||
There was a problem hiding this comment.
I think you'll need to store the value as a class property
|
@mavwolverine Do you still have the time and interest to move this forward? All good if not. |
|
@mrgrain |
Pull request was converted to draft
|
All good and totally understandable! I'm moving this into draft state for now, so we can easily filter it out until you or someone else picks it up again. 👍 |
Fixes ##632
This is replacement for PR aws/aws-cdk#23912
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license