chore(cli): allow valid enum values in telemetry data #711
+36
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: github-actions <[email protected]>
aws-cdk-automation
requested a deployment
to
integ-approval
GitHub Actions
Waiting
iliapolo
reviewed
Jul 13, 2025
| ['build-exclude']: ['something'], | ||
| }; | ||
| expect(sanitizeCommandLineArguments(argv)).toEqual({ | ||
| path: ['deploy', '$STACK1'], | ||
| parameters: { 'require-approval': '<redacted>', 'build-exclude': '<redacted>' }, | ||
| parameters: { 'build-exclude': '<redacted>' }, |
There was a problem hiding this comment.
i removed require-approval from the test 'non-boolean options are redacted' and added it as a separate test called 'enum options are allowed'
iliapolo
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enum values are defined as
choicesin thecli-type-registry.jsonfile. If the choices array exists, and if the value we get is included as a choice, then we allow that raw value to be recorded in telemetry because it is not free text. Invalid values passed in an enum property are not recorded. In practice, the CLI fails before telemetry starts withBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license