-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Fix installing setup dependencies for bundled installer on newer versions of pip #9420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9420 +/- ##
========================================
Coverage 93.39% 93.39%
========================================
Files 210 210
Lines 16983 16993 +10
========================================
+ Hits 15861 15871 +10
Misses 1122 1122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8c8f274
to
4668b95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I left a couple comments/questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🏆
) | ||
|
||
|
||
def validate_that_wheels_are_universal(dirname): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking: I don't think it's required that the wheels are universal, only that wheels are available for the platform the user is installing AWS CLI on. It doesn't look like this will be an issue anytime soon and if it is, it'll be caught the by CI so I'm fine with this.
Issue #, if available: CLI-6153
Don't think we have a GitHub issue, but this has been reported on a few Q&A sites:
Description of changes:
--find-links file://{local path}
syntax to install the packages from the bundle, rather than PyPI. At some point (not apparent from pip's changelog, still trying to pinpoint), this started throwingValueError: non-local file URIs are not supported on this platform: 'file://.
.file://
syntax since--find-links
can accept local paths (see example 10 onpip install
docs).ModuleNotFoundError: No module named 'setuptools'
since it's no longer included by default.setuptools
to ourBUILDTIME_DEPS
that we install first.setuptools
from sdist, which looks like it needs to bootstrap itself. I switched to wheels to alleviate this, though just for theBUILDTIME_DEPS
to start. Refresh bundled installer to work with modern pip/venv #4756 alluded to this as future work.urllib3
for the bundled installer to a version before2.0.0
(where they started requiringhatchling
). We previously pinnedcolorama
for a similar reason.Testing
Added new GitHub action to test making the bundle and installing it across our usual Python version + OS matrix.
I'll manually test a dry-run through the internal build system.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.