Fix incorrect socialmessaging command #9458
Open
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashovlin
reviewed
Apr 24, 2025
| { | ||
| "type": "bugfix", | ||
| "category": "socialmessaging", | ||
| "description": "Fixes incorrect customization for renaming a socialmessaging command" |
There was a problem hiding this comment.
I'd describe what is changing from a user's perspective, since "customization for renaming" is internal.
The usage of this command in CliV1 and botocore is significantly higher, so renaming it in a braking way for them is not an option. Usage is low enough in CLIv2 that we can fix this at the source and not need to maintain a complicated customization in v2; all customers currently calling this command have already been notified of this breaking change, so we can safely make it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a relatively new command that had a human error due to manually renaming it to preserve branding. All customers currently using this command are aware of this breaking change.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.