Skip to content

[Bug] Run static fleet checks only if there are static nodes #2960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

himani2411
Copy link
Contributor

@himani2411 himani2411 commented May 24, 2025

Description of changes

  • Add TOTAL_MIN_COUNT of a cluster as comment in /opt/slurm/etc/slurm_parallelcluster.conf
  • Run static fleet checks if there are any static nodes
    TODO: Move check_for_protected_mode in else for running dynamic nodes

Tests

  • Manual test for updating /opt/slurm/etc/slurm_parallelcluster.conf
    [ONGOING]
  • cluster creation of static and dynamic nodes
  • Updates with running dynamic & static nodes

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Himani Anil Deshpande added 2 commits May 23, 2025 22:02
* Run static fleet checks if there are any static nodes
@himani2411 himani2411 requested review from a team as code owners May 24, 2025 02:08
@himani2411 himani2411 marked this pull request as draft May 24, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant