Skip to content

[Subnet Prioritization] Add EnableSingleAvailabilityZone to Fleet Config #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Allenz5
Copy link

@Allenz5 Allenz5 commented Jun 16, 2025

Description of changes

Add EnableSingleAvailabilityZone parameter to fleet_config.json

Tests

  • test_fleet_config_generator.py

References

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Allenz5 Allenz5 requested review from a team as code owners June 16, 2025 17:20
}
},
CriticalError,
"Unable to find key 'EnableSingleAvailabilityZone' in the configuration file. Queue: q1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to showcase this error if Customer doesn't provide this parameter as this is not required parameter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this is a test case but we want to cover the case where we don't see this error and fleet-config.json gets created even if this parameter is not provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this fleet-config.json is what drives the scaling through node package

…ingleAvailabilityZone is not provided

Signed-off-by: Hanxuan Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants