Fixing cloudfront signer logic, and changelog #5892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanVaknin
changed the title
zoewangg
reviewed
Feb 19, 2025
| @@ -258,7 +258,7 @@ public SignedUrl getSignedUrlWithCustomPolicy(Consumer<CustomSignerRequest.Build | |||
| public SignedUrl getSignedUrlWithCustomPolicy(CustomSignerRequest request) { | |||
| String resourceUrl = request.resourceUrl(); | |||
| try { | |||
| String resourceUrlPattern = StringUtils.isEmpty(request.resourceUrlPattern()) | |||
| String resourceUrlPattern = request.resourceUrlPattern() == null | |||
There was a problem hiding this comment.
Don't we need to update tests accordingly?
There was a problem hiding this comment.
No. There is no test case that checks for "" specifically.
Both before and after the change this codepath never runs into an issue with null because it uses resourceUrl as a backfill which is guaranteed to be not null or empty.
There was a problem hiding this comment.
Gotcha, should we have had tests though ;)
RanVaknin
force-pushed
the
fix-cloudfront-signer-logic-and-changelog
branch
from
c946487 to
7dfc920
Compare
zoewangg
approved these changes
Feb 19, 2025
| @@ -258,7 +258,7 @@ public SignedUrl getSignedUrlWithCustomPolicy(Consumer<CustomSignerRequest.Build | |||
| public SignedUrl getSignedUrlWithCustomPolicy(CustomSignerRequest request) { | |||
| String resourceUrl = request.resourceUrl(); | |||
| try { | |||
| String resourceUrlPattern = StringUtils.isEmpty(request.resourceUrlPattern()) | |||
| String resourceUrlPattern = request.resourceUrlPattern() == null | |||
There was a problem hiding this comment.
Gotcha, should we have had tests though ;)
RanVaknin
force-pushed
the
fix-cloudfront-signer-logic-and-changelog
branch
from
7dfc920 to
4606ece
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing changelog and minor logic for #5862