Fixed the issue where AWS CRT HTTP client was eagerly buffering data …

[zoewangg]

…before the underlying CRT component was able to handle it and added error handling for the case where it failed to convert SDK request to CRT request

Motivation and Context

• Fixed potential connection leak issue that could happen if converting SDK request to CRT request fails.
• Fixed the issue where AWS CRT HTTP client was eagerly buffering data before the underlying CRT component was able to handle it

Modifications

• Move the request converting logic to try catch block
• Only subscribe to the publisher when CRT is ready (calling sendRequestBody). We did similar change in CRT-based S3 client but never in CRT HTTP client. Fixed the issue where CRT-based S3 client was using excessive memory #3800

Testing

Added unit tests

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed
• I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.