Skip to content

fix(chat): When user close the information card, it would close permanently #7078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: feature/agentic-chat
Choose a base branch
from

Conversation

Randall-Jiang
Copy link
Contributor

@Randall-Jiang Randall-Jiang commented Apr 17, 2025

Problem

When user close the information card, it will show up when user open a new tab

Solution

Screen.Recording.2025-04-17.at.4.37.28.PM.mov
  1. Add the global.status to make sure whenever the Q initialized, the programmerCard won't show up. (If user closed the card previously)
  2. Add the implemtation in main.ts to make sure when user close the programmer card and open a new Tab, it won't show again.

known issue: When user close the programmer mode card, it still show up on first new opened tab. But it won't show later.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@@ -11,7 +11,7 @@ import { qChatIntroMessageForSMUS, TabTypeDataMap } from './constants'
import { agentWalkthroughDataModel } from '../walkthrough/agent'
import { FeatureContext } from '../../../../shared/featureConfig'
import { RegionProfile } from '../../../../codewhisperer/models/model'

import globals from '../../../../shared/extensionGlobals'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is running in the UI but you're importing something from the node side of the extension, that's why your chat panel wont load

@Randall-Jiang Randall-Jiang force-pushed the show-abs-path branch 2 times, most recently from d1ee341 to 061b63b Compare April 17, 2025 21:49
@Randall-Jiang Randall-Jiang marked this pull request as ready for review April 17, 2025 23:28
@Randall-Jiang Randall-Jiang requested review from a team as code owners April 17, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants