move and simplify logic

aws · Dec 11, 2023 · af50d26 · af50d26
1 parent 00a1942
commit af50d26
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/internal/pkg/manifest/validate.go b/internal/pkg/manifest/validate.go
@@ -2227,11 +2227,6 @@ func validateAndPopulateNLBListenerPorts(listener NetworkLoadBalancerListener, p
 		return err
 	}
 
-	// Handle termination of TLS protocol
-	if strings.ToUpper(aws.StringValue(nlbProtocol)) == TLS {
-		nlbProtocol = aws.String(TCP)
-	}
-
 	port, err := strconv.ParseUint(aws.StringValue(nlbReceiverPort), 10, 16)
 	if err != nil {
 		return err
@@ -2248,6 +2243,11 @@ func validateAndPopulateNLBListenerPorts(listener NetworkLoadBalancerListener, p
 		targetProtocol = strings.ToUpper(aws.StringValue(nlbProtocol))
 	}
 
+	// Handle TLS termination of container exposed port protocol
+	if targetProtocol == TLS {
+		targetProtocol = TCP
+	}
+
 	// Prefer `nlb.target_container`, then existing exposed port mapping, then fallback on name of main container
 	targetContainer := mainContainerName
 	if existingContainerNameAndProtocol, ok := portExposedTo[targetPort]; ok {