Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update docs to indicate do-not-disrupt does not block expiration #7554

Merged
merged 1 commit into from
Dec 28, 2024
Merged

docs: Update docs to indicate do-not-disrupt does not block expiration #7554

merged 1 commit into from
Dec 28, 2024

Conversation

jigisha620
Copy link
Contributor

Fixes #N/A

Description
Update docs to indicate do-not-disrupt does not block expiration

How was this change tested?
NA

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner December 27, 2024 23:59
@netlify Netlify
Copy link

netlify bot commented Dec 27, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit bcda62e
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/676f3f524a58160008a9a39f
😎 Deploy Preview https://deploy-preview-7554--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12521925152

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.125%
Totals Coverage Status
Change from base Build 12402493920: 0.0%
Covered Lines: 5774
Relevant Lines: 8866
💛 - Coveralls

jmdeal
jmdeal approved these changes Dec 28, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jigisha620 jigisha620 merged commit 140ab17 into aws:main Dec 28, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdeal jmdeal jmdeal approved these changes

@jonathan-innis jonathan-innis Awaiting requested review from jonathan-innis jonathan-innis is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jigisha620 @coveralls @jmdeal