docs: make an actual policy recommendation for fips #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/fips-recommendation
branch
from
0b10d93 to
96ffa3d
Compare
toidiu
previously approved these changes
Jun 12, 2024
toidiu
reviewed
Jun 12, 2024
quic/s2n-quic/src/tests/fips.rs
Outdated
|
|
||
| #[test] | ||
| fn default_fips_test() { | ||
| // TODO switch this to `default_fips` when the policy support TLS 1.3 |
There was a problem hiding this comment.
nit: could you link this issue: #2247
toidiu
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Our documentation should make an actual recommendation for a FIPS security policy, rather than rely on the customer reading the s2n-tls docs. Ideally it would be
default_fips, but that doesn't support TLS 1.3 currently. When it does, we should update this documentation to refer to that instead.Testing:
I added a test to show the recommended policy working.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.