Add static factory methods to ApiGatewayRequestIdentity and AwsProxyRequestContext #1496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
issue #1495
Description of changes:
This PR resolves issue #1495 by implementing static factory methods for both
ApiGatewayRequestIdentity
andAwsProxyRequestContext
classes.Implemented Changes
Added
getApiGatewayRequestIdentity()
toApiGatewayRequestIdentity
class:Added
getApiGatewayRequestIdentity(String sourceIp)
toApiGatewayRequestIdentity
class:Added
getAwsProxyRequestContext()
toAwsProxyRequestContext
class:Added
getAwsProxyRequestContext(String httpMethod)
toAwsProxyRequestContext
class:Benefits
Questions for Maintainers
getAwsProxyRequestContext()
andgetApiGatewayRequestIdentity()
preferred, or would you prefer a different naming pattern likebuilder()
orof()
?I've tested these changes locally and they work as expected.
By submitting this pull request