Avoid NPE if ECR list imagese returns images without tags before images

with tags
awslabs · Dec 14, 2023 · 67ef35a · 67ef35a
1 parent e7f14f6
commit 67ef35a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...ervice/src/main/java/com/amazon/aws/partners/saasfactory/saasboost/OnboardingService.java b/...ervice/src/main/java/com/amazon/aws/partners/saasfactory/saasboost/OnboardingService.java
@@ -1181,7 +1181,7 @@ public SQSBatchResponse processValidateOnboardingQueue(SQSEvent event, Context c
                         Map<String, Object> service = (Map<String, Object>) serviceConfig.getValue();
                         Map<String, Object> serviceCompute = (Map<String, Object>) service.get("compute");
                         String ecrRepo = (String) serviceCompute.get("containerRepo");
-                        String imageTag = (String) serviceCompute.get("containerTag");
+                        String imageTag = (String) serviceCompute.getOrDefault("containerTag", "latest");
                         if (Utils.isNotBlank(ecrRepo)) {
                             try {
                                 ListImagesResponse dockerImages = ecr.listImages(request -> request
@@ -1190,7 +1190,7 @@ public SQSBatchResponse processValidateOnboardingQueue(SQSEvent event, Context c
                                 // ListImagesResponse::hasImageIds will return true if the imageIds object is not null
                                 if (dockerImages.hasImageIds()) {
                                     for (ImageIdentifier image : dockerImages.imageIds()) {
-                                        if (image.imageTag().equals(imageTag)) {
+                                        if (imageTag.equals(image.imageTag())) {
                                             imageAvailable = true;
                                             break;
                                         }