Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use public parameters in parameter store for ami id #114

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

tiationg-kho
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Use public parameters in parameter store for ami id

Testing:

Test in local by make e2e-test and ./build/simple-ec2 launch -i

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tiationg-kho tiationg-kho requested a review from a team as a code owner December 24, 2024 17:22
Copy link
Contributor

@LikithaVemulapalli LikithaVemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some inline comments

pkg/ec2helper/ec2helper.go Show resolved Hide resolved
pkg/ec2helper/ec2helper.go Show resolved Hide resolved
pkg/ec2helper/ec2helper.go Show resolved Hide resolved
pkg/question/question_test.go Show resolved Hide resolved
Copy link
Contributor

@LikithaVemulapalli LikithaVemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tiationg-kho tiationg-kho merged commit d1d4c8b into awslabs:main Jan 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants