[GSProcessing] Update GSProcessing custom split config parsing and documentation to match GConstruct. #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thvasilo
added
break back compatibility
ready
…figs whether they are single str or list[str] NOTE: GSProcessing now requires list[str] for its custom split file config input.
thvasilo
force-pushed
the
gsp-custom-split-configs
branch
from
dba7f4d to
436a886
Compare
jalencato
reviewed
Dec 19, 2024
graphstorm-processing/graphstorm_processing/data_transformations/dist_label_loader.py
Show resolved
Hide resolved
graphstorm-processing/graphstorm_processing/config/config_conversion/gconstruct_converter.py
Outdated
Show resolved
Hide resolved
| entry_val = label_custom_split_filenames.get(entry, None) | ||
| if entry_val: | ||
| if isinstance(entry_val, str): | ||
| label_custom_split_filenames[entry] = [entry_val] |
There was a problem hiding this comment.
In this way do we want to support string input for gsprocessing config?
There was a problem hiding this comment.
Yes, since GConstruct supports both, we use this to convert to list[str] which is our expectation for GSProcessing.
There was a problem hiding this comment.
Right. But I suppose the code here only convert the gconstruct config, do we also support the config in gsprocessing config?
There was a problem hiding this comment.
I would prefer having a single way to do things to avoid confusing users. This goes along with the Python principle of "There should be one-- and preferably only one --obvious way to do it." https://peps.python.org/pep-0020/
Co-authored-by: jalencato <[email protected]>
thvasilo
commented
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: GSProcessing now requires list[str] for its custom split file config input.
Issue #, if available:
Description of changes:
gsprocessing.configclasses and functions that were previously untested.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.