Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arm instructions needed for AES-XTS #211

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

nebeid
Copy link
Contributor

@nebeid nebeid commented Mar 21, 2025

Description of changes:
Added decoding for:

  • NOP
  • LD1/ST1 post-index register offset and no offset for both 64-bit and 128-bit registers
  • LD1/ST1 2 128-bit registers, post-index immediate offset
  • LDRB/STRB with (shifted) register index, no shift.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@nebeid nebeid requested review from jargh and aqjune-aws March 21, 2025 14:40
@aqjune-aws
Copy link
Collaborator

The sematest raises a failure at ARM_BASIC_STEP_TAC, specifically EXISTS_NONTRIVIAL_CONV because arm_NOP is unfolded. I think arm_NOP must be unfolded.. instruction.ml will have ARM_OPERATION_CLAUSES that lists the definitions to unfold.
On the other hand, EXISTS_NONTRIVIAL_CONV must print a better error message in this case. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants