feat: Added support for Git credential helper #121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #120 120.
Reason for this change
This is a feature request for CodeBuild created by SBT AppPlane to support cloning private Git repos.
Description of changes
I have added a field [here] (
sbt-aws/src/core-app-plane/script-job.ts
Line 241 in 137b1fc
The field I have added is to enable [git-credential-helper] (https://docs.aws.amazon.com/codebuild/latest/userguide/build-spec-ref.html#build-spec.env.git-credential-helper)
Description of how you validated changes
I updated node modules locally and added the same field in the file 'bash-job-runner.js'
I then executed
and redeployed the SBT code. In the script supplied to Codebuild I executed the following command :
With this command I was able to clone the private GitHub repo where my source code was located.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.