-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: upgrade package dependencies #148
Open
JeffreyTsang0928
wants to merge
19
commits into
awslabs:main
Choose a base branch
from
JeffreyTsang0928:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade CDK to version 2.179.0 - Update ESLint, TypeScript, Projen, and other dev dependencies - Switch from eslint-plugin-header to eslint-plugin-license-header - Update Lambda runtimes to Python 3.13 - Refactor Firehose and DynamoDB configurations for latest CDK APIs - Standardize license headers across all files - Remove unnecessary dependencies and update peer dependencies
chore: Upgrade dependencies
suhussai
requested changes
Mar 11, 2025
@@ -255,17 +265,22 @@ export class CognitoAuth extends Construct implements IAuth { | |||
customAttributes: { | |||
userRole: new cognito.StringAttribute({ mutable: true, minLen: 1, maxLen: 256 }), | |||
}, | |||
advancedSecurityMode: | |||
props?.enableAdvancedSecurityMode == false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we still taking the right action based on whether this value enableAdvancedSecurityMode
is false?
Marking this as a breaking change because it updates peerDeps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #.
Reason for this change
Upgrade dependencies such as jsii, projen, cdk
Description of changes
Upgraded packages for jsii, eslint, projen, cdk, ts-node. Added verbose license.
Description of how you validated changes
Project builds successfully indicating no issues with packages. test-sbt-aws.sh script runs successfully with no issues
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.