fix: updated contributing instructions #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e ARN to connect the two planes
suhussai
requested changes
Mar 11, 2025
| 1. Write tests for any changed code and commit | ||
| 1. Create a PR. | ||
|
|
||
| - Once the control plane has been deployed, obtain the ARN of the newly deployed event bus [here](https://us-east-1.console.aws.amazon.com/events/home?region=us-east-1#/eventbuses) |
There was a problem hiding this comment.
This is a region-specific URL, which will be confusing for customers deploying outside of us-east-1.
Maybe we can ask them to review the outputs of the ControlPlane stack to find the event bus ARN?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e ARN to connect the two planes
Issue # (if applicable)
Closes #.
Reason for this change
CONTRIBUTING.md does not instruct users to use the Eventbridge ARN from the control plane when deploying the core app plane, resulting in the deployment of the two planes without any communication. This will also result in the failure of the test scripts when provisioning and deprovisioning tenants, as there is no prior instruction to connect the two planes when deploying.
Description of changes
Edited CONTRIBUTING.md
Description of how you validated changes
N/A
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.