cfnlint v1 compatibility upgrade #192
Open
+1,341
−803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erty name and expected value.
….8. Bumping dev deps
Bumps [setuptools](https://github.com/pypa/setuptools) from 59.6.0 to 70.0.0. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst) - [Commits](pypa/setuptools@v59.6.0...v70.0.0) --- updated-dependencies: - dependency-name: setuptools dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.7 to 1.26.19. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@1.26.7...1.26.19) --- updated-dependencies: - dependency-name: urllib3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [certifi](https://github.com/certifi/python-certifi) from 2021.10.8 to 2024.7.4. - [Commits](certifi/python-certifi@2021.10.08...2024.07.04) --- updated-dependencies: - dependency-name: certifi dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [future](https://github.com/PythonCharmers/python-future) from 0.18.2 to 0.18.3. - [Release notes](https://github.com/PythonCharmers/python-future/releases) - [Changelog](https://github.com/PythonCharmers/python-future/blob/master/docs/changelog.rst) - [Commits](PythonCharmers/python-future@v0.18.2...v0.18.3) --- updated-dependencies: - dependency-name: future dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [requests](https://github.com/psf/requests) from 2.26.0 to 2.32.2. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.26.0...v2.32.2) --- updated-dependencies: - dependency-name: requests dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [black](https://github.com/psf/black) from 22.8.0 to 24.3.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@22.8.0...24.3.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [idna](https://github.com/kjd/idna) from 3.3 to 3.7. - [Release notes](https://github.com/kjd/idna/releases) - [Changelog](https://github.com/kjd/idna/blob/master/HISTORY.rst) - [Commits](kjd/idna@v3.3...v3.7) --- updated-dependencies: - dependency-name: idna dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [bandit](https://github.com/PyCQA/bandit) from 1.7.1 to 1.7.10. - [Release notes](https://github.com/PyCQA/bandit/releases) - [Commits](PyCQA/bandit@1.7.1...1.7.10) --- updated-dependencies: - dependency-name: bandit dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3 to 5. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v3...v5) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [flake8-bugbear](https://github.com/PyCQA/flake8-bugbear) from 22.4.25 to 23.3.12. - [Release notes](https://github.com/PyCQA/flake8-bugbear/releases) - [Commits](PyCQA/flake8-bugbear@22.4.25...23.3.12) --- updated-dependencies: - dependency-name: flake8-bugbear dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [radon](https://github.com/rubik/radon) from 5.1.0 to 6.0.1. - [Changelog](https://github.com/rubik/radon/blob/master/CHANGELOG) - [Commits](rubik/radon@v5.1.0...v6.0.1) --- updated-dependencies: - dependency-name: radon dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
|
Hi @sliedig! I'll review this this week. Thanks for sending this PR. |
…on to 0.3.3 in main.go
…ate resource handling - Changed the method of checking SQS Queue redrive policy by utilizing GetResourceContent instead of WalkResources. - Updated the severity return type to tflint.Severity. - Enhanced error handling and logging for better debugging. - Removed outdated commented code for clarity.
…imports across multiple rules - Changed the return type of the Severity method in various AWS serverless rules from string to tflint.Severity. - Updated import statements to use hclext and logger from the tflint-plugin-sdk for better consistency and functionality. - Enhanced code clarity by removing unused imports and ensuring uniformity in rule implementations.
- Updated the AwsSfnStateMachineTracingRule and AwsSnsTopicSubscriptionRedrivePolicyRule to utilize GetResourceContent for resource checks, enhancing consistency across rules. - Changed the return type of the Severity method to tflint.Severity for both rules. - Improved import statements by replacing hcl with hclext for better functionality. - Enhanced error handling and logging for missing attributes, ensuring clearer diagnostics. - Removed outdated commented code to improve code clarity.
- Bumped Go version from 1.21 to 1.23 in multiple workflows. - Updated TFLint setup action from v2 to v4. - Changed release-drafter action from v5 to v6. - Updated actions/checkout from v3 to v4. - Expanded Go version matrix in tests workflow to include 1.23. - Updated publishing token reference in the publish workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#191
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.