Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(evm): adding call contract with gas estimation #175

Merged
merged 12 commits into from
May 2, 2024
Merged

Conversation

re1ro
Copy link
Contributor

@re1ro re1ro commented Mar 27, 2024

  • EVM: CallContractGasEstimation
  • Depends on GMP-SDK 5.7.0

@re1ro re1ro requested a review from npty March 27, 2024 04:03
@re1ro re1ro self-assigned this Mar 27, 2024
@npty
Copy link
Member

npty commented Mar 27, 2024

@re1ro I've published @axelar-network/[email protected] to bump the dependencies version. here's the related pr. could you pls update and try running tests again?

@re1ro
Copy link
Contributor Author

re1ro commented Mar 27, 2024

@npty thank you for that! Everything passes on local now.

And I've used your fix for fsevents with

            "os": [
                "darwin",
                "linux"
            ],

package.json Outdated
@@ -22,8 +22,8 @@
"license": "ISC",
"dependencies": {
"@axelar-network/axelar-chains-config": "^0.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@axelar-network/axelar-chains-config": "^0.1.0",
"@axelar-network/axelar-chains-config": "^1.2.0",

package.json Outdated Show resolved Hide resolved
IAxelarGasService public immutable gasService;
uint256 public constant GAS_LIMIT = 200000;

event Executed(string _from, string _message);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a getter to estimate gas on this contract for composability? It'll internally call gasService.estimateGas with the right gas limit set. Calling contracts and the example script can use that instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented!

@re1ro re1ro merged commit 693fb16 into main May 2, 2024
4 checks passed
@re1ro re1ro deleted the feat/gas-estimation branch May 2, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants