-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix the phantom token details page that appears for unsubmitted txs #357
chore: fix the phantom token details page that appears for unsubmitted txs #357
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@canhtrinh I've tested the following scenario which similar to what we've discussed in the meeting:
And the data in the
|
Description
AXE-3890
Regarding to #354 and #349 issues:
When the user clicks "Register on x chain" button, we save all the token details in the postgres db first before generating transaction data for the user to sign (before the browser wallet is pop-up).
After the user submitted the transaction, we then update the record that we've saved in the previous step with
deploymentMessageId: '${txHash}-${txIndex}'
.However, when the user visits the token details page, we haven't checked if the user submitted the transaction from the
deploymentMessageId
field. We show the full token details UI page if there's any row in the db that associated with the token address.The issue arises if the transaction wasn't actually sent out to the blockchain, for instance, the user denies or closes the tx pop-up window, the transaction was dropped due to low gas price, etc.
This PR addresses the situations where the token details page was displaying incorrect information when the token registration transaction was not successfully submitted to the blockchain.
How this PR fixes the issue
This PR checks the
deploymentMessageId
field on the token details page to determine if the transaction was successfully submitted.deploymentMessageId
exists, it displays the "Full Token Details" UI, indicating the token registration process is complete:deploymentMessageId
is absent, it displays the "Register Token" UI, allowing the user to initiate the registration process:Other changes
drizzle-kit
to the latest version for compatibility with other dependencies.README.md
toapps/maestro/src/lib/drizzle/docs/
to resolve errors withdrizzle:*
commands during development.