Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: recover deployment message id when visiting token details page #431

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

SGiaccobasso
Copy link
Collaborator

@SGiaccobasso SGiaccobasso commented Aug 28, 2024

Description

Recover the deployment message id when visiting the token details page if missing.

⛑️ What was done:

  • Create query to recover message id by token id.
  • Check if the id is missing in every visit to token details page and try to recover it.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Ready to merge

🧪 How to test:

Go to the details page of a token with a missing deployment message it, check it shows as unregistered ITS token and wait for it to update.
You can achieve this by deleting the message id from the db for an existing token.

🗒️ Notes:

  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

🖼️ Recording:

Screen.Recording.2024-08-28.at.11.54.06.mov

Check how the token with the missing deployment message id updates automatically in the details page after some seconds.

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
axelar-maestro ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 4:35pm
axelar-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 4:35pm
axelar-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 4:35pm

Copy link

changeset-bot bot commented Aug 28, 2024

🦋 Changeset detected

Latest commit: 163bd05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@axelarjs/maestro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@SGiaccobasso SGiaccobasso merged commit d55c7cf into main Sep 2, 2024
5 checks passed
@SGiaccobasso SGiaccobasso deleted the feat/recover-deployment-message-id branch September 2, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants