Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth: disable transaction broadcast based on originated peer #690

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

minh-bq
Copy link
Collaborator

@minh-bq minh-bq commented Feb 12, 2025

This commit adds a flag --disable-tx-broadcast.from so that node operator can provide enode ids (e.g. --disable-tx-broadcast.from cfa5f00c55eba79f359c9d95f5c0b2bb8e173867ffbb6e212c6799a52918502519e56650970e34caf1cd17418d4da46c3243588578886c3b4f8c42d1934bf108). Transaction originated from the peers have those enode ids will not be broadcasted to any other peers.

cmd/utils/flags.go Outdated Show resolved Hide resolved
eth/handler.go Show resolved Hide resolved
Copy link
Contributor

@chiphamskymavis chiphamskymavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some chore comments, but overall LGTM!

This commit adds a flag --disable-tx-broadcast.from so that node operator can
provide enode ids (e.g. --disable-tx-broadcast.from
cfa5f00c55eba79f359c9d95f5c0b2bb8e173867ffbb6e212c6799a52918502519e56650970e34caf1cd17418d4da46c3243588578886c3b4f8c42d1934bf108).
Transaction originated from the peer has those enode ids will not be
broadcasted to any other peers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants