Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filterx invalid utf8 fix for unset_empties #309

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

bshifter
Copy link
Member

  • pre-validation of utf8 input string on eval
  • targets literal generator list parse-time utf8 validation

alltilla
alltilla previously approved these changes Sep 26, 2024
Copy link
Member

@alltilla alltilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also replace the compare function to be g_utf8_collate even for ignorecase=false? Thinking about the different ways an utf-8 string can be represented but have the same meaning.

@bshifter bshifter dismissed alltilla’s stale review September 26, 2024 09:01

The merge-base changed after approval.

@alltilla
Copy link
Member

Please rebase to main to drop the first commit.

@alltilla
Copy link
Member

Let's talk about UTF-8 IRL, this PR is good for now.

alltilla
alltilla previously approved these changes Sep 26, 2024
@bshifter bshifter dismissed alltilla’s stale review September 26, 2024 13:22

The merge-base changed after approval.

@bshifter bshifter force-pushed the filterx-invalid-utf8-fix branch from 2693f17 to 72321d3 Compare September 26, 2024 13:24
@alltilla alltilla merged commit d53d84f into axoflow:main Sep 27, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants