-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filterx parse cef/leef #1 #324
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshifter
force-pushed
the
filterx-parse-cef
branch
5 times, most recently
from
October 5, 2024 12:16
df2a9b3
to
1e2484b
Compare
alltilla
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really solid PR!
bshifter
force-pushed
the
filterx-parse-cef
branch
3 times, most recently
from
October 8, 2024 12:34
5ffac71
to
b546be2
Compare
bshifter
force-pushed
the
filterx-parse-cef
branch
from
October 8, 2024 12:47
b546be2
to
3bb3ff8
Compare
alltilla
reviewed
Oct 9, 2024
I only had 2 really minor comments, otherwise approve. Very nice PR :) |
bshifter
force-pushed
the
filterx-parse-cef
branch
from
October 9, 2024 08:40
3bb3ff8
to
cde2085
Compare
bshifter
force-pushed
the
filterx-parse-cef
branch
from
October 9, 2024 09:14
cde2085
to
f93c9f2
Compare
…miters in unquoted values Signed-off-by: shifter <[email protected]>
…parser Signed-off-by: shifter <[email protected]>
…at-parser Signed-off-by: shifter <[email protected]>
Signed-off-by: shifter <[email protected]>
…mat-parser this version supports only LEEF:1.0 atm, LEEF:2.0 will be added as a separate feature Signed-off-by: shifter <[email protected]>
Signed-off-by: shifter <[email protected]>
Signed-off-by: shifter <[email protected]>
Signed-off-by: shifter <[email protected]>
Signed-off-by: shifter <[email protected]>
bshifter
force-pushed
the
filterx-parse-cef
branch
from
October 9, 2024 14:27
f93c9f2
to
3d16c1c
Compare
alltilla
approved these changes
Oct 9, 2024
alltilla
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the
parse_cef
andparse_leef
functions to the filterx module.Currently,
parse_leef
supports only LEEF version 1.0. Support for LEEF 2.0 will be included in a future update.examples: