Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filterx parse cef/leef #1 #324

Merged
merged 9 commits into from
Oct 9, 2024
Merged

Conversation

bshifter
Copy link
Member

@bshifter bshifter commented Oct 5, 2024

Introduces the parse_cef and parse_leef functions to the filterx module.
Currently, parse_leef supports only LEEF version 1.0. Support for LEEF 2.0 will be included in a future update.

examples:

filterx {
   leef = parse_leef(leef_message);
   cef = parse_cef(cef_message);
}

@bshifter bshifter force-pushed the filterx-parse-cef branch 5 times, most recently from df2a9b3 to 1e2484b Compare October 5, 2024 12:16
Copy link
Member

@alltilla alltilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really solid PR!

modules/cef/event-format-parser.c Outdated Show resolved Hide resolved
modules/cef/event-format-parser.c Outdated Show resolved Hide resolved
modules/cef/event-format-parser.c Outdated Show resolved Hide resolved
modules/cef/event-format-parser-cfg.h Outdated Show resolved Hide resolved
modules/cef/event-format-parser-cfg.h Show resolved Hide resolved
modules/cef/event-format-parser.c Outdated Show resolved Hide resolved
modules/cef/event-format-parser.c Outdated Show resolved Hide resolved
modules/cef/event-format-parser.c Outdated Show resolved Hide resolved
modules/cef/filterx-func-parse-cef.c Outdated Show resolved Hide resolved
modules/cef/filterx-func-parse-cef.h Outdated Show resolved Hide resolved
@bshifter bshifter force-pushed the filterx-parse-cef branch 3 times, most recently from 5ffac71 to b546be2 Compare October 8, 2024 12:34
@bshifter bshifter requested a review from alltilla October 8, 2024 12:35
modules/cef/event-format-parser.c Outdated Show resolved Hide resolved
modules/cef/event-format-parser.c Outdated Show resolved Hide resolved
@alltilla
Copy link
Member

alltilla commented Oct 9, 2024

I only had 2 really minor comments, otherwise approve. Very nice PR :)

@bshifter bshifter requested a review from alltilla October 9, 2024 08:53
@alltilla alltilla merged commit fb32316 into axoflow:main Oct 9, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants