Filterx small changes #443
Merged
+28
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alltilla
reviewed
Jan 7, 2025
bazsi
force-pushed
the
filterx-small-changes
branch
2 times, most recently
from
1225c34 to
719cce3
Compare
|
This is now based on top of #444 and with that this is green now. |
bazsi
force-pushed
the
filterx-small-changes
branch
from
719cce3 to
137e380
Compare
alltilla
previously approved these changes
Jan 15, 2025
bazsi
dismissed
alltilla’s stale review
The merge-base changed after approval.
alltilla
previously approved these changes
Jan 15, 2025
|
Thanks for this! After a rebase we can merge. |
bazsi
dismissed
alltilla’s stale review
The merge-base changed after approval.
alltilla
force-pushed
the
filterx-small-changes
branch
from
137e380 to
c833004
Compare
alltilla
approved these changes
Jan 15, 2025
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
…ction Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
filterx-small-changes
branch
from
c833004 to
ca310d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are three basically independent patches, but I didn't want to open a separate PR for all of these. Let's try these in one go. Should be relatively straightforward to review.