Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logmsg: add generation counter #447

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

bazsi
Copy link
Member

@bazsi bazsi commented Jan 7, 2025

This adds a counter to LogMessage to track changes made to the NVTable. Any set_value() would increment that counter. Any other fields (timestamps, etc) are not yet tracked, but probably should....

@OverOrion OverOrion self-requested a review January 14, 2025 10:29
@OverOrion OverOrion self-assigned this Jan 14, 2025
@bazsi bazsi force-pushed the logmsg-generation-counter branch from 8947d6d to 381ef64 Compare January 17, 2025 09:22
Signed-off-by: Balazs Scheidler <[email protected]>
@bazsi bazsi force-pushed the logmsg-generation-counter branch from 381ef64 to e1fb711 Compare January 18, 2025 07:30
Copy link
Contributor

@OverOrion OverOrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

For the curious, the previous struct size was 160 bytes with holes, now only 152 (no holes!), so yay as well for this! 🚀

@OverOrion OverOrion merged commit e814ffb into axoflow:main Jan 21, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants