Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: support overwrite when merge config. (#1394)" #1404

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jint-lzxy
Copy link
Collaborator

This reverts commit 7056741.

Sorry for the noise but I'm a lil confused about this new option...? Like idk if the performance difference between these two is even that big, and maybe it's not actually working as expected?

This reverts commit 7056741.

Sorry for the noise but I'm a lil confused about this new option...? Like idk if
the performance difference between these two is even that big, and maybe it's
not actually working as expected?
@ayamir
Copy link
Owner

ayamir commented Jan 19, 2025

overwrite option is the only solution to delete pre-defined something, like I want to define edgy.nvim left region with NeoTree rather than NvimTree. Otherwise I need to use function to repeat lots of content the same with defaults.

@Jint-lzxy
Copy link
Collaborator Author

overwrite option is the only solution to delete pre-defined something

But I think this might break some users' expectations of the loader right 🤔 Also think I mentioned vim.NIL elsewhere too, it's like a user object so maybe we can use that to signal "erasure" of the field instead?

@ayamir
Copy link
Owner

ayamir commented Jan 26, 2025

Marking a option as nil is not enough, overwrite is an irreplaceable way to acheive delete and re-define.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants