Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changes to sensor state structure #64

Open
caseycesari opened this issue Feb 28, 2019 · 0 comments
Open

Make changes to sensor state structure #64

caseycesari opened this issue Feb 28, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@caseycesari
Copy link
Contributor

In both #62 and #63, additional properties related to the sensor API data were added to the sensor GeoJSON state. I think it might be worth consolidating state.map.sensors into state.app.sensors for better clarity.

Along with that, the sensor API data and the sensor water quality ratings state should probably live on each sensor in state.app.sensors rather than as a separate, consolidated block. The change in state structure may require changes in some of the mechanics of how the data is retrieved. However, the sensor data should be retrieved independently, as it is now, since the availability of each sensor varies and the app is designed in a way that we don't need every sensor to retrieve data successfully. Some relevant discussion can be found at #62 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants