Wire up ratings and sensor data feed to frontend #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fungjj92
force-pushed
the
jf/wire-up-ratings-to-frontend
branch
from
cd46bb8 to
f8fa9e0
Compare
caseycesari
approved these changes
Mar 4, 2019
| const scoreWithUnit = `${score} ${unit}`; | ||
| const range = `${HealthyRanges[v].lower}-${ | ||
| HealthyRanges[v].upper | ||
| } ${unit}`; |
There was a problem hiding this comment.
Nice job abstracting this out.
Translating scores to ratings is still fuzzy. There's not yet direction on how to decide a "warning" rating for a variable. Consolidates all sensor-related data to the `app` redux store Refs #41
fungjj92
force-pushed
the
jf/wire-up-ratings-to-frontend
branch
from
77cb5cd to
b737d62
Compare
|
Thanks, yeah looks cool! Rebased on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This sprint, we set up all the data needed for the front-end. This PR subs in dynamically generated data to the frontend, which previously showed static dummy data.
Connects #41
Connects #43
(I accidentally did both)
Demo
Notes
You will see some TODOs. We will need some guidance from the client about how the variable score translates to qualitative buckets (positive, warning, and negative) given its range (i.e. 1-50NTU for Turbidity). For now, it was decided to just categorize scores as positive and negative if they are in or outside the range, respectively.
I was tempted to roll in #64, but am anticipating a fair amount of conflict rebasing on #63 already so I forewent that.
Testing Instructions
Netlify will suffice.